src: replace var for (let|const) in utilities module#18814
Closed
jvelezpo wants to merge 1 commit intonodejs:masterfrom
jvelezpo:utils-replace-var
Closed
src: replace var for (let|const) in utilities module#18814jvelezpo wants to merge 1 commit intonodejs:masterfrom jvelezpo:utils-replace-var
jvelezpo wants to merge 1 commit intonodejs:masterfrom
jvelezpo:utils-replace-var
Conversation
Update Utilities module to replace var for let or const
nodejs-github-bot
added
the
util
jasnell
approved these changes
Feb 16, 2018
BridgeAR
approved these changes
Feb 16, 2018
BridgeAR
added
the
author ready
Member
|
Light-CI https://ci.nodejs.org/job/node-test-commit-light/278/ (this should be enough for this PR) |
Member
|
Code changes like this really ought to have a full CI run.. https://ci.nodejs.org/job/node-test-pull-request/13223/ ... it's likely overkill but still preferable. |
Contributor
Author
|
Hey @jasnell first thanks for taking the time to read and review this PR. |
mmarchini
approved these changes
Feb 17, 2018
Member
|
Landed in ca79fc5 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 22, 2018
Update Utilities module to replace var for let or const PR-URL: nodejs#18814 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Update Utilities module to replace var for let or const PR-URL: #18814 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Update Utilities module to replace var for let or const PR-URL: nodejs#18814 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Utilities module to replace var for let or const depending on the case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
utils